update for redisvl 0.6.0 #1524
update for redisvl 0.6.0 #1524
Conversation
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
Couple of suggestions, but minor stuff, so I'll approve.
| * **Return type:** | ||
| None | ||
|
|
||
| #### `NOTE` |
There was a problem hiding this comment.
Is it possible to render these notes in {{< note >}} ... {{< /note >}} shortcodes instead of h4 headings? No major problem if not, but currently the notes appear as headings at the same level as the method names (although I doubt anyone will confuse them for methods).
There was a problem hiding this comment.
What should be wrapped in {{< note >}} ... {{< /note >}}? Just the literal NOTE or the whole thing?
| * [Add route references](semantic_router/#add-route-references) | ||
| * [Get route references](semantic_router/#get-route-references) | ||
| * [Delete route references](semantic_router/#delete-route-references) |
There was a problem hiding this comment.
These are subheadings of Semantic Routing, so should be indented (looks like they currently aren't indented):
| * [Add route references](semantic_router/#add-route-references) | |
| * [Get route references](semantic_router/#get-route-references) | |
| * [Delete route references](semantic_router/#delete-route-references) | |
| * [Add route references](semantic_router/#add-route-references) | |
| * [Get route references](semantic_router/#get-route-references) | |
| * [Delete route references](semantic_router/#delete-route-references) |
There was a problem hiding this comment.
Looks like this is an existing problem, for instance for the Hash vs JSON Storage subheadings. I'll look into this
There was a problem hiding this comment.
This is caused by some inconsistencies in the redisvl jupyter notebooks. I'll open some prs to get those fixed at the source.
update for redisvl 0.6.0